Bug 86388

Summary: Pagination splits lines that could fit on a single page if it were not for their top leading
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dglazkov, eric, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 86445    
Bug Blocks:    
Attachments:
Description Flags
Make tall lines split in the top leading so that the visible content fits on a single page
darin: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-01 none

mitz
Reported 2012-05-14 11:58:39 PDT
Pagination splits lines that could fit on a single page if it were not for their top leading
Attachments
Make tall lines split in the top leading so that the visible content fits on a single page (5.45 KB, patch)
2012-05-14 12:04 PDT, mitz 		darin: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-01 (839.97 KB, application/zip)
2012-05-14 12:43 PDT, WebKit Review Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2012-05-14 12:01:47 PDT
<rdar://problem/10288903>
mitz
Comment 2 2012-05-14 12:04:33 PDT
Created attachment 141764 [details] Make tall lines split in the top leading so that the visible content fits on a single page
Darin Adler
Comment 3 2012-05-14 12:12:19 PDT
Comment on attachment 141764 [details] Make tall lines split in the top leading so that the visible content fits on a single page View in context: https://bugs.webkit.org/attachment.cgi?id=141764&action=review Looks good. > Source/WebCore/ChangeLog:10 > + When a lineâs visible content fits on a page, but adding the top leading makes it taller than Bad quote mark?
mitz
Comment 4 2012-05-14 12:15:12 PDT
(In reply to comment #3) > > + When a lineâs visible content fits on a page, but adding the top leading makes it taller than > > Bad quote mark? No, this is bug 75394. I wish I knew how to fix it. Thanks for the review!
WebKit Review Bot
Comment 5 2012-05-14 12:43:31 PDT
Comment on attachment 141764 [details] Make tall lines split in the top leading so that the visible content fits on a single page Attachment 141764 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12684467 New failing tests: fast/multicol/split-in-top-margin.html
WebKit Review Bot
Comment 6 2012-05-14 12:43:36 PDT
Created attachment 141770 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
mitz
Comment 7 2012-05-14 13:03:18 PDT
(In reply to comment #5) > (From update of attachment 141764 [details]) > Attachment 141764 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/12684467 > > New failing tests: > fast/multicol/split-in-top-margin.html I am going to switch the test to using Ahem.
mitz
Comment 8 2012-05-14 13:04:00 PDT
Fixed in <http://trac.webkit.org/r116986>
Note You need to log in before you can comment on or make changes to this bug.