Bug 87339

Summary:

There are too many poorly named functions to create a fragment from markup

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

HTML Editing

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, darin, dglazkov, enrica, eric, gustavo, morrita, rafaelw, tonikitoo, tony, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

87454

Attachments:

Description	Flags
Cleanup	none
Fixed build	none
Archive of layout-test-results from ec2-cr-linux-04	none
Archive of layout-test-results from ec2-cr-linux-02	none
Fixed a bug	none
Fixed Qt build	none

Ryosuke Niwa

Reported 2012-05-23 21:34:39 PDT

Range::createDocumentFragmentForElement, createFragmentFromSource (one in markup.cpp and another one in XSLTProcessor.cpp), and HTMLElement::insertAdjacentHTML all have very similar code, and the different between createDocumentFragmentForElement and two versions of createFragmentFromSource is not clear at all from function names.

Attachments
Cleanup (16.83 KB, patch) 2012-05-23 21:50 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Fixed build (16.84 KB, patch) 2012-05-23 23:00 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-04 (606.63 KB, application/zip) 2012-05-24 00:00 PDT, WebKit Review Bot	no flags	Details
Archive of layout-test-results from ec2-cr-linux-02 (488.61 KB, application/zip) 2012-05-24 01:07 PDT, WebKit Review Bot	no flags	Details
Fixed a bug (16.75 KB, patch) 2012-05-24 01:13 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Fixed Qt build (20.58 KB, patch) 2012-05-24 09:56 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2012-05-23 21:50:20 PDT

Created attachment 143727 [details] Cleanup

Gustavo Noronha (kov)

Comment 2 2012-05-23 22:07:08 PDT

Comment on attachment 143727 [details] Cleanup Attachment 143727 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12799051

WebKit Review Bot

Comment 3 2012-05-23 22:07:45 PDT

Comment on attachment 143727 [details] Cleanup Attachment 143727 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12792080

Build Bot

Comment 4 2012-05-23 22:12:15 PDT

Comment on attachment 143727 [details] Cleanup Attachment 143727 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12807008

Build Bot

Comment 5 2012-05-23 22:20:08 PDT

Comment on attachment 143727 [details] Cleanup Attachment 143727 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12805037

Ryosuke Niwa

Comment 6 2012-05-23 23:00:13 PDT

Created attachment 143736 [details] Fixed build

WebKit Review Bot

Comment 7 2012-05-24 00:00:52 PDT

Comment on attachment 143736 [details] Fixed build Attachment 143736 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12798101 New failing tests: fast/dom/insertAdjacentHTML-DocumentFragment-crash.html fast/dynamic/insertAdjacentHTML.html fast/dom/HTMLElement/insertAdjacentHTML-errors.html

WebKit Review Bot

Comment 8 2012-05-24 00:00:58 PDT

Created attachment 143748 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

WebKit Review Bot

Comment 9 2012-05-24 01:07:18 PDT

Comment on attachment 143736 [details] Fixed build Attachment 143736 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12795105 New failing tests: fast/dom/insertAdjacentHTML-DocumentFragment-crash.html fast/dynamic/insertAdjacentHTML.html fast/dom/HTMLElement/insertAdjacentHTML-errors.html

WebKit Review Bot

Comment 10 2012-05-24 01:07:22 PDT

Created attachment 143754 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Ryosuke Niwa

Comment 11 2012-05-24 01:13:11 PDT

Created attachment 143755 [details] Fixed a bug

Early Warning System Bot

Comment 12 2012-05-24 01:27:57 PDT

Comment on attachment 143755 [details] Fixed a bug Attachment 143755 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12792125

Early Warning System Bot

Comment 13 2012-05-24 01:38:08 PDT

Comment on attachment 143755 [details] Fixed a bug Attachment 143755 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/12799101

Eric Seidel (no email)

Comment 14 2012-05-24 09:01:55 PDT

Comment on attachment 143755 [details] Fixed a bug Qt doesn't like you.

Ryosuke Niwa

Comment 15 2012-05-24 09:56:56 PDT

Created attachment 143844 [details] Fixed Qt build

Eric Seidel (no email)

Comment 16 2012-05-24 13:40:30 PDT

Comment on attachment 143844 [details] Fixed Qt build Thanks!

WebKit Review Bot

Comment 17 2012-05-24 14:15:37 PDT

Comment on attachment 143844 [details] Fixed Qt build Clearing flags on attachment: 143844 Committed r118414: <http://trac.webkit.org/changeset/118414>

WebKit Review Bot

Comment 18 2012-05-24 14:15:43 PDT

All reviewed patches have been landed. Closing bug.

Darin Adler

Comment 19 2012-05-24 14:44:45 PDT

Comment on attachment 143844 [details] Fixed Qt build View in context: https://bugs.webkit.org/attachment.cgi?id=143844&action=review > Source/WebCore/editing/markup.h:56 > + PassRefPtr<DocumentFragment> createContextualFragment(const String&, Element*, FragmentScriptingPermission); I noticed an extra space after a comma here. > Source/WebCore/html/HTMLElement.cpp:581 > + ExceptionCode ignoredEc = 0; // FIXME: We should propagate a syntax error exception out here. Should be ignoredEC.

Ryosuke Niwa

Comment 20 2012-05-24 21:05:45 PDT

Comment on attachment 143844 [details] Fixed Qt build View in context: https://bugs.webkit.org/attachment.cgi?id=143844&action=review >> Source/WebCore/editing/markup.h:56 >> + PassRefPtr<DocumentFragment> createContextualFragment(const String&, Element*, FragmentScriptingPermission); > > I noticed an extra space after a comma here. Fixing it in https://bugs.webkit.org/show_bug.cgi?id=87454. >> Source/WebCore/html/HTMLElement.cpp:581 >> + ExceptionCode ignoredEc = 0; // FIXME: We should propagate a syntax error exception out here. > > Should be ignoredEC. Ditto.

Note You need to log in before you can comment on or make changes to this bug.