Bug 88813

Summary: Change RenderTableSection::calcRowLogicalHeight to round rather than floor height
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, jchaffraix, leviw, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Emil A Eklund
Reported 2012-06-11 15:24:01 PDT
Change RenderTableSection::calcRowLogicalHeight to round the logicalHeight instead of flooring it. This matches our rounding logic elsewhere and results in table rows better matching the expected height.
Attachments
Patch (8.37 KB, patch)
2012-06-11 15:35 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.75 KB, patch)
2012-06-14 09:27 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-06-11 15:35:30 PDT
Created attachment 146932 [details] Patch
Julien Chaffraix
Comment 2 2012-06-12 15:48:18 PDT
Comment on attachment 146932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146932&action=review > LayoutTests/fast/sub-pixel/table-rows-have-stable-height.html:65 > + var height = r((20 + i) * 0.93 + i); Where did you find this formula? The whole test cases is based on this being right, yet it's super cryptic.
Emil A Eklund
Comment 3 2012-06-12 15:53:51 PDT
(In reply to comment #2) > (From update of attachment 146932 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=146932&action=review > > > LayoutTests/fast/sub-pixel/table-rows-have-stable-height.html:65 > > + var height = r((20 + i) * 0.93 + i); > > Where did you find this formula? The whole test cases is based on this being right, yet it's super cryptic. The formula isn't critical at all, it is just a way to have each row be a different height with subpixel precision.
Emil A Eklund
Comment 4 2012-06-12 16:59:47 PDT
Expanding a bit. The purpose of the test is to check whether the reported height of a row matches the actual height and that it isn't depending on the location of the row. The way it does that is by setting the size of a row in an off-screen table to a subpixel value, measure the result resulting height and then use that height to size a row in the on screen table. This is explained in the test. I'd be happy to expand on it you feel it is still unclear.
Emil A Eklund
Comment 5 2012-06-13 13:34:50 PDT
Julien, any chance you could take another look at this today?
Julien Chaffraix
Comment 6 2012-06-13 14:34:24 PDT
Comment on attachment 146932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146932&action=review > LayoutTests/ChangeLog:8 > + Add new test ensuring that rows are painted with the desired height when It's not really 'painted' more 'laid out'. > LayoutTests/fast/sub-pixel/table-rows-have-stable-height.html:45 > + </p> Nit: I like to have the bug number in the output. >>> LayoutTests/fast/sub-pixel/table-rows-have-stable-height.html:65 >>> + var height = r((20 + i) * 0.93 + i); >> >> Where did you find this formula? The whole test cases is based on this being right, yet it's super cryptic. > > The formula isn't critical at all, it is just a way to have each row be a different height with subpixel precision. I think a comment on why we are doing that would be welcome. Something like: // Set the size to a non-pixel bound value. The exact formula isn't important, what matters is that each rows has a different size.
Emil A Eklund
Comment 7 2012-06-13 14:35:51 PDT
Thanks for the review Julien, I'll make the changes you suggested!
Emil A Eklund
Comment 8 2012-06-14 09:27:15 PDT
Created attachment 147601 [details] Patch for landing
WebKit Review Bot
Comment 9 2012-06-14 13:08:42 PDT
Comment on attachment 147601 [details] Patch for landing Clearing flags on attachment: 147601 Committed r120354: <http://trac.webkit.org/changeset/120354>
WebKit Review Bot
Comment 10 2012-06-14 13:08:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.