Bug 88924

Summary: [chromium] Add an allocation step for CCRenderer before drawing a frame
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, enne, jamesr, nduca, piman, vangelis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89474    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Dana Jansens
Reported 2012-06-12 14:47:20 PDT
[chromium] Add an allocation step for CCRenderer before drawing a frame
Attachments
Patch (6.57 KB, patch)
2012-06-12 14:47 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (24.79 KB, patch)
2012-06-14 17:23 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (35.63 KB, patch)
2012-06-18 12:37 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (5.95 KB, patch)
2012-06-19 12:40 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (5.92 KB, patch)
2012-06-19 13:17 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch for landing (27.75 KB, patch)
2012-06-19 14:21 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.05 KB, patch)
2012-06-19 14:22 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.75 KB, patch)
2012-06-19 14:23 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-06-12 14:47:49 PDT
Created attachment 147168 [details] Patch
Dana Jansens
Comment 2 2012-06-13 08:35:16 PDT
Not for review yet (misclick on EWS) just putting up steps as I work on this RenderSurface textures in LRC code. (Longing for github :))
Dana Jansens
Comment 3 2012-06-14 17:23:37 PDT
Created attachment 147686 [details] Patch
Dana Jansens
Comment 4 2012-06-18 12:37:33 PDT
Created attachment 148150 [details] Patch another peek before i hook this up to LRC.
Dana Jansens
Comment 5 2012-06-18 12:40:55 PDT
I'm planning to do something like this for allocation of RenderPass textures (this is always in the root/host compositor). I'm going to start hooking this up to LRC and see how it fares, I had done this earlier without the CCScopedTexture class and it was a bit ugly, so I've cleaned it up some before attempting again. If anyone wants to look at it and tell me they like/dislike the design ideas here that would be very nice as I'm still not overly committed to it. Basic idea: Add a step before drawing to decide what passes will get allocated, and which saved textures from the previous frame will not be clobbered and will be available when they are needed in the current frame. Then when drawing we already know which passes we draw, and can allocate textures as needed on the fly.
Dana Jansens
Comment 6 2012-06-19 12:40:56 PDT
Created attachment 148391 [details] Patch This is just the piece to add the allocation step to the draw-a-frame process.
Dana Jansens
Comment 7 2012-06-19 13:17:23 PDT
Created attachment 148402 [details] Patch Decide allocations/Set the memory limit before reserving/testing cached surface textures.
Adrienne Walker
Comment 8 2012-06-19 14:17:16 PDT
Comment on attachment 148402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148402&action=review R=me. > Source/WebCore/platform/graphics/chromium/cc/CCRenderer.h:71 > + // This method should be a no-op in a nested compositor that does not render its passes directly. Not sure this comment adds anything. Other functions will probably be a no-op too. We can document that in the derived interface.
Dana Jansens
Comment 9 2012-06-19 14:20:16 PDT
Comment on attachment 148402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148402&action=review thanks! >> Source/WebCore/platform/graphics/chromium/cc/CCRenderer.h:71 >> + // This method should be a no-op in a nested compositor that does not render its passes directly. > > Not sure this comment adds anything. Other functions will probably be a no-op too. We can document that in the derived interface. Ya.. good call.
Dana Jansens
Comment 10 2012-06-19 14:21:04 PDT
Created attachment 148419 [details] Patch for landing
Dana Jansens
Comment 11 2012-06-19 14:22:09 PDT
Created attachment 148420 [details] Patch for landing
Dana Jansens
Comment 12 2012-06-19 14:23:49 PDT
Created attachment 148422 [details] Patch for landing
Dana Jansens
Comment 13 2012-06-19 14:23:55 PDT
Learning about webkit-patch land-safely :|
WebKit Review Bot
Comment 14 2012-06-19 15:19:04 PDT
Comment on attachment 148422 [details] Patch for landing Clearing flags on attachment: 148422 Committed r120759: <http://trac.webkit.org/changeset/120759>
WebKit Review Bot
Comment 15 2012-06-19 15:19:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.