Bug 92593

Summary: In flipped blocks, a point on the top edge of a box is considered outside the box (and vice versa)
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
When comparing y coordinates in flipped blocks, make strict inequalities non-strict and vice versa
simon.fraser: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from gce-cr-linux-06 none

mitz
Reported 2012-07-29 09:22:43 PDT
In flipped blocks, a point on the top edge of a box is considered outside the box (and vice versa)
Attachments
When comparing y coordinates in flipped blocks, make strict inequalities non-strict and vice versa (12.47 KB, patch)
2012-07-29 09:37 PDT, mitz 		simon.fraser: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-06 (437.03 KB, application/zip)
2012-07-29 10:13 PDT, WebKit Review Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2012-07-29 09:37:32 PDT
Created attachment 155174 [details] When comparing y coordinates in flipped blocks, make strict inequalities non-strict and vice versa
WebKit Review Bot
Comment 2 2012-07-29 10:13:01 PDT
Comment on attachment 155174 [details] When comparing y coordinates in flipped blocks, make strict inequalities non-strict and vice versa Attachment 155174 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13388197 New failing tests: fast/writing-mode/flipped-blocks-hit-test-line-edges.html
WebKit Review Bot
Comment 3 2012-07-29 10:13:04 PDT
Created attachment 155175 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Simon Fraser (smfr)
Comment 4 2012-07-29 10:19:48 PDT
Comment on attachment 155174 [details] When comparing y coordinates in flipped blocks, make strict inequalities non-strict and vice versa View in context: https://bugs.webkit.org/attachment.cgi?id=155174&action=review > Source/WebCore/rendering/RenderBlock.cpp:4966 > + if (pointInLogicalContents.y() < firstRootBoxWithChildrenTop > + || (blocksAreFlipped && pointInLogicalContents.y() == firstRootBoxWithChildrenTop)) { Would be nice to have a helper function to make these tests more readable. A similar pattern is repeated 5 times in this patch.
mitz
Comment 5 2012-07-29 10:28:21 PDT
Fixed in <http://trac.webkit.org/r123980>.
Note You need to log in before you can comment on or make changes to this bug.