Bug 92636

Summary: [Qt][WK1] REGRESSION(r123988) It made fast/writing-mode/flipped-blocks-hit-test-line-edges.html fail
Product: WebKit Reporter: János Badics <jbadics>
Component: Tools / TestsAssignee: Marcelo Lira <marcelo.lira>
Status: RESOLVED FIXED    
Severity: Normal CC: jbadics, marcelo.lira, mitz, ossy, rniwa, webkit.review.bot, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 79666, 92597    
Attachments:
Description Flags
Patch none

János Badics
Reported 2012-07-30 05:20:04 PDT
r123988 made this test fail on WebKit1. The diff is the following: --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/writing-mode/flipped-blocks-hit-test-line-edges-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/writing-mode/flipped-blocks-hit-test-line-edges-actual.txt @@ -7,6 +7,6 @@ PASS: offset at (160,26) was 26. PASS: offset at (60,25) was 24. PASS: offset at (160,25) was 26. -PASS: offset at (60,24) was 26. +FAIL: offset at (60,24) was 24. Expected 26. PASS: offset at (160,24) was 26. You can see the original bug at ​https://bugs.webkit.org/show_bug.cgi?id=92597
Attachments
Patch (1.46 KB, patch)
2012-09-25 14:38 PDT, Marcelo Lira 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Arvai
Comment 1 2012-07-30 05:30:08 PDT
*** Bug 92639 has been marked as a duplicate of this bug. ***
Csaba Osztrogonác
Comment 2 2012-07-30 06:18:42 PDT
Skipped by https://trac.webkit.org/changeset/124018, please unskip it with the proper fix.
mitz
Comment 3 2012-07-30 07:16:06 PDT
The test is failing because of the different selection mode used in some non-OS X ports.
Marcelo Lira
Comment 4 2012-09-25 14:38:01 PDT
Created attachment 165677 [details] Patch
Ryosuke Niwa
Comment 5 2012-09-25 18:42:45 PDT
Does the test pass now? Why can we unskip the test?
Csaba Osztrogonác
Comment 6 2012-09-26 00:58:07 PDT
Comment on attachment 165677 [details] Patch It seems it passes now, so let's unskip it.
WebKit Review Bot
Comment 7 2012-09-26 01:02:26 PDT
Comment on attachment 165677 [details] Patch Clearing flags on attachment: 165677 Committed r129606: <http://trac.webkit.org/changeset/129606>
WebKit Review Bot
Comment 8 2012-09-26 01:02:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.