Bug 94792

Summary: Enable sub-pixel layout for the GTK port
Product: WebKit Reporter: Zan Dobersek <zan>
Component: WebKitGTKAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, eae, leviw, mrobinson, pnormand
Priority: P2 Keywords: Gtk, LayoutTestFailure
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 89572, 115304    
Bug Blocks: 85532    
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2012-08-23 01:53:51 PDT
This bug will cover enabling the sub-pixel layout on the GTK port. I believe the branch for the next stable release series will be created soon - I'd recommend proceeding with enabling this feature only after that.
Attachments
Patch (1.04 KB, patch)
2013-04-15 14:20 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dominik Röttsches (drott)
Comment 1 2012-10-11 07:10:24 PDT
So you consider bug 89572 required for enabling sub pixel layout on GTK as well? Do you see the same issue that I observed initially that there's too much rebaselining required on GTK without that patch? Maybe together we can make another attempt and working with the Chromium gardeners to get it landed. Last time I tried I couldn't quite get them to rebase these 6000+ cases - but if we're two (ports), we might have more luck.
Zan Dobersek
Comment 2 2012-10-11 07:14:12 PDT
(In reply to comment #1) > So you consider bug 89572 required for enabling sub pixel layout on GTK as well? Do you see the same issue that I observed initially that there's too much rebaselining required on GTK without that patch? > Maybe together we can make another attempt and working with the Chromium gardeners to get it landed. Last time I tried I couldn't quite get them to rebase these 6000+ cases - but if we're two (ports), we might have more luck. I haven't really checked out how this patch affects the number of tests that would need rebaselining, but it wouldn't come around as smart to enable the subpixel layout, rebaseline gazillion of tests, get that patch landed and rebaseline gazillion of tests again. I'd rather help out the Chromium gardeners do their rebaselining when this patch lands.
Dominik Röttsches (drott)
Comment 3 2013-01-23 06:19:57 PST
As you've probably seen on some other bugs, we've enabled it on EFL, and bug 89572 wasn't actually the core of the issue. Updating FreeType was. And no rebaselines required on the Chromium side. However, after my discussions with Werner Lemberg, there will be another change in FreeType that might affect baselines - so, if you plan to enable sub-pixel layout on GTK, I would wait for FreeType 2.4.12 - or in other words any release that includes http://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=e0469372be3870a5ad60b2c4586e9c281357bd28
Zan Dobersek
Comment 4 2013-04-15 14:20:14 PDT
Created attachment 198186 [details] Patch
Zan Dobersek
Comment 5 2013-04-20 12:20:34 PDT
Comment on attachment 198186 [details] Patch Clearing flags on attachment: 198186 Committed r148793: <http://trac.webkit.org/changeset/148793>
Zan Dobersek
Comment 6 2013-04-20 12:20:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.