Bug 9488

Summary:

Animated GIFs do not respect transforms in SVG

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

SVG

Assignee:

Maciej Stachowiak <mjs>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Test case (with remote images)	none
patch that fixes handling of partial repaints in SVG - many things were busted	none
better patch that fixes many more repaint issues.	none
even better patch (doesn't break opacity) plus some manual tests	darin: review+

Eric Seidel (no email)

Reported 2006-06-17 15:03:24 PDT

Animated GIFs do not respect transforms in SVG See example.

Attachments
Test case (with remote images) (940 bytes, image/svg+xml) 2006-06-17 15:03 PDT, Eric Seidel (no email)	no flags	Details
patch that fixes handling of partial repaints in SVG - many things were busted (11.16 KB, patch) 2006-06-18 01:19 PDT, Maciej Stachowiak	no flags	Details Formatted Diff Diff
better patch that fixes many more repaint issues. (19.53 KB, patch) 2006-06-18 20:04 PDT, Maciej Stachowiak	no flags	Details Formatted Diff Diff
even better patch (doesn't break opacity) plus some manual tests (55.39 KB, patch) 2006-06-19 01:53 PDT, Maciej Stachowiak	darin: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2006-06-17 15:03:54 PDT

Created attachment 8890 [details] Test case (with remote images)

Maciej Stachowiak

Comment 2 2006-06-18 01:19:43 PDT

Created attachment 8898 [details] patch that fixes handling of partial repaints in SVG - many things were busted

Darin Adler

Comment 3 2006-06-18 16:43:23 PDT

Comment on attachment 8898 [details] patch that fixes handling of partial repaints in SVG - many things were busted looks good; r=me

Maciej Stachowiak

Comment 4 2006-06-18 20:04:58 PDT

Created attachment 8916 [details] better patch that fixes many more repaint issues. This needs test cases landed with it. Maybe manual tests for now.

Maciej Stachowiak

Comment 5 2006-06-19 01:53:30 PDT

Created attachment 8919 [details] even better patch (doesn't break opacity) plus some manual tests This breaks the metrics (but not rendering) on some svg layout tests, probably should not be landed until I investigate that. But might be worth preliminary review.

Maciej Stachowiak

Comment 6 2006-06-19 02:42:21 PDT

On second thought... I think the metrics changes in the layout tests are all ok. They seem to more accurately represent the actual bounding boxes.

David Kilzer (:ddkilzer)

Comment 7 2006-06-19 20:06:34 PDT

Committed as revision r14918.

Note You need to log in before you can comment on or make changes to this bug.