Bug 95952

Summary: New tests introduced in r127704 fail
Product: WebKit Reporter: Kristóf Kosztyó <kkristof>
Component: Tools / TestsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, gyuyoung.kim, kadam, kkristof, mikhail.pozdnyakov, ossy, rakuco, szledan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87008, 91110    
Attachments:
Description Flags
Patch
none
Patch
none
Unskipping last tests none

Kristóf Kosztyó
Reported 2012-09-06 01:58:57 PDT
These tests fail on Qt and the Efl bot. fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/viewport/viewport-limits-adjusted-for-no-user-scale-control-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/viewport/viewport-limits-adjusted-for-no-user-scale-control-actual.txt @@ -1,2 +1,5 @@ -ALERT: PASS - +layer at (0,0) size 800x600 + RenderView at (0,0) size 800x600 +layer at (0,0) size 800x600 + RenderBlock {HTML} at (0,0) size 800x600 + RenderBody {BODY} at (8,8) size 784x584 fast/viewport/viewport-limits-adjusted-for-no-user-scale.html --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/viewport/viewport-limits-adjusted-for-no-user-scale-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/viewport/viewport-limits-adjusted-for-no-user-scale-actual.txt @@ -1,2 +1,5 @@ -ALERT: PASS - +layer at (0,0) size 800x600 + RenderView at (0,0) size 800x600 +layer at (0,0) size 800x600 + RenderBlock {HTML} at (0,0) size 800x600 + RenderBody {BODY} at (8,8) size 784x584
Attachments
Patch (2.79 KB, patch)
2012-09-06 12:33 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (3.54 KB, patch)
2012-09-06 12:36 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Unskipping last tests (1.34 KB, patch)
2012-10-04 11:32 PDT, Tullio Lucena 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kristóf Kosztyó
Comment 1 2012-09-06 02:06:18 PDT
I skipped them on Qt in the r127709 <http://trac.webkit.org/changeset/127709> to paint the bots green.
Ádám Kallai
Comment 2 2012-09-06 02:07:12 PDT
Are these results correct? Could you check it, please?
Kristóf Kosztyó
Comment 3 2012-09-06 02:10:55 PDT
Also fail on Gtk
Mikhail Pozdnyakov
Comment 4 2012-09-06 03:18:51 PDT
Also fails on EFL
Adam Barth
Comment 5 2012-09-06 09:09:33 PDT
Thanks. Will investigate.
Adam Barth
Comment 6 2012-09-06 10:37:19 PDT
Will look. It's strange that they're getting render tree dumps and not text dumps.
Adam Barth
Comment 7 2012-09-06 12:33:40 PDT
Created attachment 162556 [details] Patch
Adam Barth
Comment 8 2012-09-06 12:36:07 PDT
Created attachment 162557 [details] Patch
mitz
Comment 9 2012-09-06 12:52:30 PDT
Comment on attachment 162557 [details] Patch Thanks!
WebKit Review Bot
Comment 10 2012-09-06 16:40:33 PDT
Comment on attachment 162557 [details] Patch Clearing flags on attachment: 162557 Committed r127798: <http://trac.webkit.org/changeset/127798>
WebKit Review Bot
Comment 11 2012-09-06 16:40:37 PDT
All reviewed patches have been landed. Closing bug.
Tullio Lucena
Comment 12 2012-10-04 11:32:34 PDT
Created attachment 167145 [details] Unskipping last tests
Csaba Osztrogonác
Comment 13 2012-10-09 05:59:42 PDT
(In reply to comment #12) > Created an attachment (id=167145) [details] > Unskipping last tests unskipped by https://trac.webkit.org/changeset/130752 But please don't upload new patched to a closed bug, because nobody will notice about it.
Note You need to log in before you can comment on or make changes to this bug.