Bug 98227

Summary: DateTimeYearFieldElement should respect min/max values specified by page authors
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, mifenton, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 98228, 98230    
Bug Blocks: 97299, 97997, 98226    
Attachments:
Description Flags
Patch
none
Patch 2 morrita: review+, webkit.review.bot: commit-queue-

Kent Tamura
Reported 2012-10-02 20:48:11 PDT
DateTimeYearFieldElement should respect min/max values specified by page authors.
Attachments
Patch (21.32 KB, patch)
2012-10-03 00:31 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch 2 (26.77 KB, patch)
2012-10-03 04:19 PDT, Kent Tamura 		morrita: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-10-03 00:31:29 PDT
Created attachment 166819 [details] Patch
WebKit Review Bot
Comment 2 2012-10-03 02:28:29 PDT
Comment on attachment 166819 [details] Patch Attachment 166819 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14125690 New failing tests: fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes.html fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic.html fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes.html fast/forms/week-multiple-fields/week-multiple-fields-appearance-style.html fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html
yosin
Comment 3 2012-10-03 03:03:01 PDT
Comment on attachment 166819 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166819&action=review > Source/WebCore/html/shadow/DateTimeFieldElements.cpp:456 > + return range().isInRange(fullYear) ? fullYear : DateTimeNumericFieldElement::defaultValueForStepDown(); In current UI document, we use current year if we author doesn't specify "min" attribute, otherwise we use minimum value. If you think using current year if it is in-range is better, please update UI document.
Kent Tamura
Comment 4 2012-10-03 03:12:13 PDT
(In reply to comment #3) > In current UI document, we use current year if we author doesn't specify "min" attribute, otherwise we use minimum value. > If you think using current year if it is in-range is better, please update UI document. I see. I'll update the implementation.
Kent Tamura
Comment 5 2012-10-03 04:19:01 PDT
Created attachment 166854 [details] Patch 2
Hajime Morrita
Comment 6 2012-10-03 20:33:26 PDT
Comment on attachment 166854 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=166854&action=review > Source/WebCore/html/shadow/DateTimeEditElement.cpp:164 > + yearParams.minIsSpecified = false; Nit: could be yearParams.minIsSpecified = m_parameters.minimumYear != m_parameters.undefinedYear(); > Source/WebCore/html/shadow/DateTimeFieldElements.h:177 > + : minimumYear(-1) Why not use undefinedYear()?
Kent Tamura
Comment 7 2012-10-03 20:38:55 PDT
Comment on attachment 166854 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=166854&action=review >> Source/WebCore/html/shadow/DateTimeFieldElements.h:177 >> + : minimumYear(-1) > > Why not use undefinedYear()? Because we'd like to avoid dependency from DateTime*FieldElement to DateTimeEditElement
WebKit Review Bot
Comment 8 2012-10-03 20:43:42 PDT
Comment on attachment 166854 [details] Patch 2 Rejecting attachment 166854 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: /WebCore/html/shadow/DateTimeNumericFieldElement.h patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt patching file LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Hajime Mor..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14129925
Kent Tamura
Comment 9 2012-10-03 21:32:41 PDT
Committed r130362: <http://trac.webkit.org/changeset/130362>
Note You need to log in before you can comment on or make changes to this bug.