RESOLVED FIXED191916
Web Inspector: "No Filter Results" in navigation sidebar should have a button to clear filters 
https://bugs.webkit.org/show_bug.cgi?id=191916
Summary Web Inspector: "No Filter Results" in navigation sidebar should have a button...
Devin Rousso
Reported 2018-11-22 15:11:34 PST
We add a button in other places (e.g. Network tab, Audit tab), and we should be consistent.
Attachments
Patch (10.13 KB, patch)
2018-11-23 10:21 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (980.95 KB, image/png)
2018-11-23 10:22 PST, Devin Rousso 		no flags
Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.62 MB, application/zip)
2018-11-23 16:52 PST, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-11-23 10:21:43 PST
Created attachment 355524 [details] Patch
Devin Rousso
Comment 2 2018-11-23 10:22:03 PST
Created attachment 355525 [details] [Image] After Patch is applied
EWS Watchlist
Comment 3 2018-11-23 16:52:09 PST Comment hidden (obsolete)
EWS Watchlist
Comment 4 2018-11-23 16:52:11 PST Comment hidden (obsolete)
Joseph Pecoraro
Comment 5 2018-11-26 09:22:17 PST
Comment on attachment 355524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355524&action=review r=me > Source/WebInspectorUI/UserInterface/Views/FilterBarButton.js:46 > + toggle(value) Would it be easier to add a new function? Reset?
Devin Rousso
Comment 6 2018-11-26 10:15:06 PST
Comment on attachment 355524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355524&action=review >> Source/WebInspectorUI/UserInterface/Views/FilterBarButton.js:46 >> + toggle(value) > > Would it be easier to add a new function? Reset? I think this better matches the DOM `classList` API, so I'd prefer to keep it as is. Additionally, this means that there is a single path for all functionality, which should make future maintenance easier :)
WebKit Commit Bot
Comment 7 2018-11-26 11:01:13 PST
Comment on attachment 355524 [details] Patch Clearing flags on attachment: 355524 Committed r238502: <https://trac.webkit.org/changeset/238502>
WebKit Commit Bot
Comment 8 2018-11-26 11:01:14 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-11-26 11:03:44 PST
<rdar://problem/46249823>
Note You need to log in before you can comment on or make changes to this bug.