RESOLVED DUPLICATE of bug 276081277654
run-webkit-tests exit code shouldn't depend on number of unexpected results 
https://bugs.webkit.org/show_bug.cgi?id=277654
Summary run-webkit-tests exit code shouldn't depend on number of unexpected results
Sam Sneddon [:gsnedders]
Reported 2024-08-05 16:12:25 PDT
Currently, if we get the expected output but exit with non-zero, EWS will totally ignore this: https://github.com/WebKit/WebKit/blob/e9e196408b4460466726b2ac2f42e709e559e764/Tools/CISupport/ews-build/steps.py#L4113-L4114 We practically have to do this, because the exit code is actually just the number of regressions: https://github.com/WebKit/WebKit/blob/e9e196408b4460466726b2ac2f42e709e559e764/Tools/Scripts/webkitpy/port/base.py#L961-L966 It would be probably be better to define an exit code which means "we had regressions", as we then don't end up in situations where a single exit code can mean multiple things.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-08-05 16:12:38 PDT
<rdar://problem/133250341>
Elliott Williams
Comment 2 2024-08-29 14:50:24 PDT
I think this is fixed by the changes landed in https://bugs.webkit.org/show_bug.cgi?id=276081. *** This bug has been marked as a duplicate of bug 276081 ***
Sam Sneddon [:gsnedders]
Comment 3 2024-09-04 18:51:57 PDT
They got reverted in bug 277749 :(
Note You need to log in before you can comment on or make changes to this bug.